Introduce HAML-Lint for HAML files #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnir
added
ruby
deivid-rodriguez
temporarily deployed
to
bundler-site-tnir-haml--sq3fx1
Signed-off-by: Takuya Noguchi <[email protected]>
deivid-rodriguez
temporarily deployed
to
bundler-site-tnir-haml--sq3fx1
|
Shouldn't this fail because of the inconsistent quotes when the idea of adding |
deivid-rodriguez
approved these changes
Jul 27, 2022
There was a problem hiding this comment.
Oh, I understand. We need to enable the StringLiterals cop in RuboCop since haml-lint will simply respect your RuboCop configuration.
Then ok, regarding the rest of the rules I don't have a strong opinion. I guess we're already enforcing the rules you set, so it seems like a good starting point.
This was referenced Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #774
Note: this does not include fix in single/double quotes due to missing RuboCop configurations (see #775)
Signed-off-by: Takuya Noguchi [email protected]